Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllInOne doesn't support priorityClass #1601

Closed
arminc opened this issue Oct 27, 2021 · 5 comments · Fixed by #2218
Closed

AllInOne doesn't support priorityClass #1601

arminc opened this issue Oct 27, 2021 · 5 comments · Fixed by #2218
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arminc
Copy link

arminc commented Oct 27, 2021

Describe the bug
The query, agent and collector allow us to set the priorityClassName but the AllInOne doesn't.

To Reproduce
AllInOne doesn't have the priorityClassName

type JaegerAllInOneSpec struct {

While the Collector for example does have it:

PriorityClassName string `json:"priorityClassName,omitempty"`

Expected behavior
To be able to specify priorityClassName for the AllInOne.

Version (please complete the following information):
Latest

@arminc arminc added the bug Something isn't working label Oct 27, 2021
@pavolloffay pavolloffay removed the bug Something isn't working label Nov 1, 2021
@pavolloffay
Copy link
Member

thanks for submitting the issue.

@arminc would you like to contribute this feature?

@arminc
Copy link
Author

arminc commented Nov 3, 2021

@pavolloffay I was planning to but very busy, will try to fix it when I can find some time.

@djsly
Copy link

djsly commented Nov 8, 2021

@pavolloffay the esCleaner doesnt support priorityClass neither, I'm not sure if we should add that as a requirement to this issue @arminc or if its best to create another issue just for the esCleaner job

@frzifus frzifus added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 23, 2022
@csp197
Copy link
Contributor

csp197 commented Mar 7, 2023

@pavolloffay
if this issue is still pending, I can pick it up. It looks like an easy feature.

I can add the priorityClass option to the JaegerAllInOneSpec.

@sonofgibs
Copy link
Contributor

@arminc @pavolloffay the above pr solves this issue and is ready for review thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants