-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AllInOne doesn't support priorityClass #1601
Comments
thanks for submitting the issue. @arminc would you like to contribute this feature? |
@pavolloffay I was planning to but very busy, will try to fix it when I can find some time. |
@pavolloffay the esCleaner doesnt support priorityClass neither, I'm not sure if we should add that as a requirement to this issue @arminc or if its best to create another issue just for the esCleaner job |
@pavolloffay I can add the priorityClass option to the |
@arminc @pavolloffay the above pr solves this issue and is ready for review thanks! |
Describe the bug
The query, agent and collector allow us to set the
priorityClassName
but the AllInOne doesn't.To Reproduce
AllInOne doesn't have the
priorityClassName
jaeger-operator/pkg/apis/jaegertracing/v1/jaeger_types.go
Line 368 in 39bdf76
While the Collector for example does have it:
jaeger-operator/pkg/apis/jaegertracing/v1/jaeger_types.go
Line 441 in 39bdf76
Expected behavior
To be able to specify
priorityClassName
for the AllInOne.Version (please complete the following information):
Latest
The text was updated successfully, but these errors were encountered: