Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.29.0 and later fail to start with default allInOne strategy: ElasticsearchList missing #1687

Closed
mrethers opened this issue Dec 22, 2021 · 1 comment · Fixed by #1688
Closed
Assignees
Labels
bug Something isn't working

Comments

@mrethers
Copy link

Describe the bug
After upgrading to v1.29.0, my Jaeger CR fails when using all defaults (AllInOne, memory storage). The controller indicates the following error:

2021-12-22T00:40:02.243Z	ERROR	controller-runtime.manager.controller.jaeger	Reconciler error	{"reconciler group": "jaegertracing.io", "reconciler kind": "Jaeger", "name": "jaeger", "namespace": "perficient-operators", "error": "no kind is registered for the type v1.ElasticsearchList in scheme \"pkg/runtime/scheme.go:100\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214

To Reproduce

  1. Install operator v1.29.0+ on Openshift
  2. Create a default Jaeger CR
  3. Observe the controller logs

Expected behavior
Operator should not care about Elasticsearch when the strategy is allInOne and continue with memory storage. I haven't tested when the strategy is Elasticsearch but I'm assuming it would also fail....

Version (please complete the following information):

  • Openshift 4.8
  • Jaeger Operator v.1.29.0

What troubleshooting steps did you try?
Downgrading to v1.28.0 worked

Additional context
Seems like the migration to operator-sdk 1.13 in commit 91e3b69 is missing the registration of the Elasticsearch kind?

There was a similar issue reported previously: https://github.com/jaegertracing/jaeger-operator/pull/366/files

@mrethers mrethers added the bug Something isn't working label Dec 22, 2021
@rubenvp8510
Copy link
Collaborator

HI thanks for catching this issue, I'll try to reproduce it,

It is strange that the e2e tests haven't cached this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants