Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example application(s) #57

Closed
jpkrohling opened this issue Oct 10, 2018 · 5 comments
Closed

Add example application(s) #57

jpkrohling opened this issue Oct 10, 2018 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jpkrohling
Copy link
Contributor

As seen on #52 (comment) , we need a simple application that generates traces. This application can then be used in the different deployment scenarios and e2e tests.
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 10, 2018
@jpkrohling jpkrohling mentioned this issue Oct 10, 2018
Merged
@annanay25
Copy link
Member

Could we use the HOTRod application here?

@pavolloffay
Copy link
Member

depends for what we need it. If it's to showcase operator then yes. If it's for e2e tests I would rather have something simpler. The hotrod can change and it would break tests.

We could even use more sophisticated app to generate spans like - jaegertracing/jaeger#1245 or https://github.com/yurishkuro/microsim

@jpkrohling
Copy link
Contributor Author

The main goal of this application is to provide users with a simple application to assess their environment is sane. Similarly, we'll use it for our e2e tests. I'd rather not use Hot ROD, but rather, something that generates a fixed number of spans/traces per request, so that we can ensure all the expected data was received by the collector.

@jpkrohling
Copy link
Contributor Author

We have a sample CR based on the image we use for e2e tests. This might be sufficient for now.

@jpkrohling
Copy link
Contributor Author

https://github.com/jaegertracing/jaeger-operator/blob/master/deploy/examples/business-application-injected-sidecar.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpkrohling @pavolloffay @annanay25