[v2] Ensure similar naming for query service metrics

[Wise-Wizard]

Which problem is this PR solving?

This PR addresses a part of the issue #5633

Description of the changes
This is a Draft PR to achieve Observability Parity between V1 and V2 components by configuring OTEL Collector config files to initialise internal tracer and metrics
How was this change tested?

The changes were tested by running the following command:

make test

CI actions

Checklist

• I have read CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (12f8fbb) to head (3f5c5ce).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5785   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files         342      342           
  Lines       16519    16520    +1     
=======================================
+ Hits        15966    15967    +1     
  Misses        363      363           
  Partials      190      190           

Flag	Coverage Δ
badger_v1	8.05% <ø> (ø)
badger_v2	1.81% <ø> (ø)
cassandra-3.x-v1	16.61% <ø> (ø)
cassandra-3.x-v2	1.74% <ø> (ø)
cassandra-4.x-v1	16.61% <ø> (ø)
cassandra-4.x-v2	1.74% <ø> (ø)
elasticsearch-6.x-v1	18.78% <ø> (+0.01%)	⬆️
elasticsearch-7.x-v1	18.83% <ø> (ø)
elasticsearch-8.x-v1	19.02% <ø> (-0.02%)	⬇️
elasticsearch-8.x-v2	1.80% <ø> (ø)
grpc_v1	9.52% <ø> (+0.01%)	⬆️
grpc_v2	7.14% <ø> (+0.01%)	⬆️
kafka-v1	9.74% <ø> (ø)
kafka-v2	1.81% <ø> (ø)
memory_v2	1.81% <ø> (+0.01%)	⬆️
opensearch-1.x-v1	18.88% <ø> (ø)
opensearch-2.x-v1	18.89% <ø> (+0.01%)	⬆️
opensearch-2.x-v2	1.80% <ø> (ø)
unittests	95.07% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

can you generate the metrics diff and link her (you can upload it to https://gist.github.com/)

[Wise-Wizard]

can you generate the metrics diff and link her (you can upload it to https://gist.github.com/)

https://gist.github.com/Wise-Wizard/d8a9399566e2131dc722b8698a994f95

[yurishkuro]

any idea why this one shows in v1 only, while the other two jaeger_query_xxx metrics show in common? It seems all three would be produced by the same code.

        "jaeger_query_requests_total": {
            "operation": "find_trace_ids",
            "result": "err"
        },

[Wise-Wizard]

any idea why this one shows in v1 only, while the other two jaeger_query_xxx metrics show in common? It seems all three would be produced by the same code.

        "jaeger_query_requests_total": {
            "operation": "find_trace_ids",
            "result": "err"
        },

It has the total suffix attached to it for some reason.

[yurishkuro]

What about storage metrics emitted by the collector?

[Wise-Wizard]

collector

Which metrics exactly?

[yurishkuro]

storage metrics. E.g. we have decorator for SpanReader interface, so when collector saves spans to storage it emits the metrics - we expect to see those from v2 as well.

[Wise-Wizard]

storage metrics. E.g. we have decorator for SpanReader interface, so when collector saves spans to storage it emits the metrics - we expect to see those from v2 as well.

Yes, I wrapped the span reader initialized in Query V2 with the decorator, and those are the jaeger_query_metrics which are seen on :8888