Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Provider has hard coded urls #492

Open
tyamell opened this issue Oct 20, 2014 · 1 comment
Open

Github Provider has hard coded urls #492

tyamell opened this issue Oct 20, 2014 · 1 comment

Comments

@tyamell
Copy link

tyamell commented Oct 20, 2014

I'm trying to use securesocial with an enterprise version of Github. Because the get authenticated user URL is hard coded https://github.com/jaliss/securesocial/blob/master/module-code/app/securesocial/core/providers/GitHubProvider.scala#L33

The library doesn't work. It would be create if that URL was configurable like the other URLs.

@jaliss
Copy link
Owner

jaliss commented Oct 21, 2014

Good point, thanks @tyamell. You can work around this if you create a subclass of GitHubProvider and override the value there. Then register your implementation in RuntimeEnvironment instead of the default one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants