DI-2029: Add SQLAlchemy DB type #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rcharriol
commented
Nov 5, 2021
Rcharriol
commented
- Updated CHANGELOG file
- Created test for the code changes
- If required, bumped the version
- If required, updated the requirements.txt file
The dockerfile assumes you got the data-commmon in the folder, so you can build the last version Also theres some dirty logs all over the place, to have visibility
viniolivieri
requested changes
Nov 8, 2021
migratron/command/run_migration.py
Outdated
Comment on lines
248
to
252
| spark_conf={ | ||
| "spark.sql.catalog.hive_prod": "org.apache.iceberg.spark.SparkCatalog", | ||
| "spark.sql.catalog.hive_prod.type": "hive", | ||
| "spark.jars.packages" : "org.apache.iceberg:iceberg-spark3-runtime:0.12.0", | ||
| "spark.sql.catalog.hive_prod.uri": "thrift://hive-metastore:9083" |
There was a problem hiding this comment.
Suggested change
| spark_conf={ | |
| "spark.sql.catalog.hive_prod": "org.apache.iceberg.spark.SparkCatalog", | |
| "spark.sql.catalog.hive_prod.type": "hive", | |
| "spark.jars.packages" : "org.apache.iceberg:iceberg-spark3-runtime:0.12.0", | |
| "spark.sql.catalog.hive_prod.uri": "thrift://hive-metastore:9083" | |
| jars=["s3://artifacts.jampp.com/dw/code/iceberg-spark3-runtime-bc41476.jar"], | |
| spark_conf={ | |
| "spark.sql.catalog.iceberg": "org.apache.iceberg.spark.SparkCatalog", | |
| "spark.sql.catalog.iceberg.type": "hive", | |
| "spark.sql.catalog.iceberg.uri": "thrift://hive-metastore:9083" |
viniolivieri
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.