Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand to non-solve endpoints #192

Open
haz opened this issue Dec 27, 2024 · 2 comments
Open

Expand to non-solve endpoints #192

haz opened this issue Dec 27, 2024 · 2 comments

Comments

@haz
Copy link

haz commented Dec 27, 2024

First example of a hosted service that is non-solver based: https://solver.planning.domains:5001/docs/val

Wasn't able to make it work when running through the editor -- it asks for the other argument, and I tried putting in the file name for the plan (the third new argument here), and it wasn't able to locate it.

I think if the argument is of type file, then a file selection dialog may be in order.

@jan-dolejsi
Copy link
Owner

jan-dolejsi commented Dec 30, 2024

Hosted val? Great. I need to see how to distinguish planner from another tool by looking at the meta data.

It is by the validate vs solve in the

"endpoint": {
      "services": {
        "validate": ...

That should be straightforward. But then we should not have it available in the VS Code extension as a planner.

Btw, can the plan argument be omitted? Can we return json file rather? This library https://github.com/jan-dolejsi/ai-planning-val.js parses the output of VAL and returns a structure that is more usable. What would it take to include it? It is node.js package (I may have a Python equivalent somewhere). Where is the code for this VAL wrapper? I am sniffing around. It is not this one in planutils. Nothing under planning-as-a-service. Where do I find it pls?

@haz
Copy link
Author

haz commented Jan 1, 2025

It is by the validate vs solve ...

Ya, we've not yet formally defined what types of endpoint services we allow, as val is the first non-solver to enter the fray.

But then we should not have it available in the VS Code extension as a planner.

Fair point. But could we settle on an API for what's returned so that it could still be used in some way? Would be useful if we add more things like problem generators or transformers.

Where is the code for this VAL wrapper? I am sniffing around. It is not this one in planutils. Nothing under planning-as-a-service. Where do I find it pls?

Indeed, you have the right one. A Python wrapper would work well there (node.js would require additional dependencies). Depending on the return type, it will process what it finds differently. We, indeed, have a type dedicated to json:

So the approach would be...

  1. Dig up the python wrapper
  2. Include that in the VAL planutils package (to be optionally called by that bash script you linked)
  3. Change the manifest to run for json and return that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants