Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Mustache.parse returns an array of Tokens #657

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

bbrooks
Copy link
Contributor

@bbrooks bbrooks commented Mar 27, 2018

In the README the return type for Mustache.parse is listed as a String. It's actually an array of Tokens.

In the README the return type for Mustache.parse is listed as a String. It's actually an array of Tokens.
Copy link

@jasonm23 jasonm23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@bbrooks
Copy link
Contributor Author

bbrooks commented Jun 18, 2018

@jasonm23 I can't merge this, who will?

@bbrooks
Copy link
Contributor Author

bbrooks commented Jun 18, 2018

Closing and reopening to trigger rebuild

@bbrooks bbrooks closed this Jun 18, 2018
@bbrooks bbrooks reopened this Jun 18, 2018
@jasonm23
Copy link

We'd need to have this merged by a collaborator / member / owner.

@janl

@phillipj phillipj merged commit 85a2c2d into janl:master Jun 18, 2018
@phillipj
Copy link
Collaborator

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants