Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with custom delimiters #659

Closed
nkcjs opened this issue May 4, 2018 · 3 comments
Closed

Problem with custom delimiters #659

nkcjs opened this issue May 4, 2018 · 3 comments

Comments

@nkcjs
Copy link

nkcjs commented May 4, 2018

Setting Anticipant Result
{{=<% %>==}} <% %>= <% %>

image

change to

if (type === '=') {
  value = scanner.scanUntil(closingTagRe);
  if (value.charAt(value.length - 1) !== '=')
    throw new Error('Setting in template failure');
  value = value.slice(0, -1).trim();
}
@simon-c-wong
Copy link

I've submitted PR for this

@phillipj
Copy link
Collaborator

As the support for custom delimiters got improved late 2018 in #643 and subsequent PRs, this bug needs to be re-tested before considering a plausible fix.

@phillipj
Copy link
Collaborator

Closing this for now due to lack of response from issue author. If it indeed still is an issue for what you're trying to do, don't hesitate re-opening the issue for further investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants