Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter 'assets' implicitly has an 'any' type. #1243

Closed
Austaras opened this issue Jul 12, 2019 · 3 comments
Closed

Parameter 'assets' implicitly has an 'any' type. #1243

Austaras opened this issue Jul 12, 2019 · 3 comments

Comments

@Austaras
Copy link
Contributor

Expected behaviour

No typing error when using TypeScript

Current behaviour

version 4.0.0-beta.7

ERROR in /home/chla/Code/template/node_modules/html-webpack-plugin/typings.d.ts(105,11):
TS7006: Parameter 'assets' implicitly has an 'any' type.

ERROR in /home/chla/Code/template/node_modules/html-webpack-plugin/typings.d.ts(114,11):
TS7006: Parameter 'assets' implicitly has an 'any' type.

Environment

tsc 3.5.3 with noImplicitAny enabled

fix

manually add any type to assets will fix this error

@jantimon
Copy link
Owner

Oh thanks for the report.
Probably we can just use the typings from here:

* @param {{
publicPath: string,
js: Array<string>,
css: Array<string>,
manifest?: string,
favicon?: string
}} assets

Could you please create a pull request for this?

@Austaras
Copy link
Contributor Author

done

@jantimon
Copy link
Owner

jantimon commented Jul 18, 2019

Released in 4.0.0-beta.8

@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants