Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should not recommend users registering jobs using django-apscheduler's
@register_job
decorator, since theid
it automatically assigned to a job is a bit long and tedious, such asFinancialCharts.management.commands.runapscheduler.getIOER_CSV
andFinancialCharts.management.commands.runapscheduler.createLIBOR_Rate_csv
, not that useful, I think we should encourage users to adopt APScheduler's decorator@scheduler.scheduled_job
to register a job, which requires users manually name eachid
, so lead to betterid
readability . I just hold the Occam's razor principle here - "entities should not be multiplied without necessity", thus I think django-apscheduler's@register_job
decorator should only reside in the source code for backward compatibility.