Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE.txt or LICENSE or LICENSE.md #22

Closed
bmarwell opened this issue Apr 8, 2019 · 5 comments
Closed

Add LICENSE.txt or LICENSE or LICENSE.md #22

bmarwell opened this issue Apr 8, 2019 · 5 comments
Labels

Comments

@bmarwell
Copy link

bmarwell commented Apr 8, 2019

The code from scream3r is LGPL.
I suggest we add the according license to each file and to the root of the github project.

@tresf
Copy link

tresf commented Apr 9, 2019

I suggest we add the according license to each file and to the root of the github project.

FYI, the license (specifically LGPL 3.0) is already mentioned in each file.

Here's an example I've used in LGPL projects:

/**
 * @author Johnny Doe
 *
 * Copyright (C) 2018 Johnny Doe
 * LGPL 2.1 This is free software.  This software and source code are released under
 * the "LGPL 3.0 License".  A copy of this license should be distributed with
 * this software. https://www.gnu.org/licenses/lgpl-3.0.en.html
 */

... and then LICENSE.TXT with the actual license body. We may also choose to simply leave the existing headers and just upload a LICENSE.TXT.

@bmarwell
Copy link
Author

bmarwell commented Apr 9, 2019

Sure, leave the headers and add the LICENSE file. As soon as I see it there, I'll add it to the pom.xml as mentioned in #23.

tresf added a commit that referenced this issue Apr 9, 2019
Adds LGPL 3.0 license file per #22
@tresf
Copy link

tresf commented Apr 9, 2019

Added to master. image

@tresf
Copy link

tresf commented Apr 9, 2019

@bmhm I'll leave the pom.xml stuff to you and then we can close this out as completed, right?

bmarwell added a commit that referenced this issue Apr 10, 2019
@tresf
Copy link

tresf commented Apr 10, 2019

Add LICENSE to pom.xml. Fixes #22. 2d31761

<rant>... minor but I'm not that excited about explicitly attaching LGPL 3.0 in source but then hard-linking to whatever gnu.org has at "lgpl.html", which is subject to change.

Fortunately... since the license specifically mentions...

or * (at your option) any later version.

... then we're in the clear. Note, "lgpl.html" (LGPL 3.0) has been the same for about 12 years, I'd expect this link to have been the same for most of that time. For these reasons, lgpl.html probably won't change anytime soon -- but once it does -- we would need to link to the "old version" section where 3.0 gets stashed at that time. Alternately, we may choose to bump to 4.0, etc by modifying the source files. Gnu should be more responsible about permalinks, but that's out of our control and of no consequence.</rant>

@bmhm thanks for finishing this up. Closing as the license is clear in GitHub, source and Maven.

@tresf tresf closed this as completed Apr 10, 2019
tresf pushed a commit that referenced this issue Apr 10, 2019
* Change maven id and project name to just "jssc" at "io.github.java-native" namespace
* Adds two releasable jars (platform-specific jar and uber jar).  TODO: add non-shaded fat jar #21
* Allow cmake to parse version info from pom.xml
* Adds ability to skip native compilation steps including cmake and tests
* Leverages maven-assembly-plugin for better classifier to the default artifact
* Alphabetize, organize and remove hard-coding of dependencies/variables
* Adds Travis-CI for many platforms.  Note, some binaries are not yet usable, sorry!
* Adds Ubuntu 14.04 cross-compiled binaries to the source tree. TODO: Move to git-lfs
* Add LICENSE to pom.xml (#22)
@tresf tresf mentioned this issue Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants