Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile and property for fat-jar. Fixes #21. #43

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Conversation

bmarwell
Copy link

@bmarwell bmarwell commented Apr 14, 2019

Adds a property and a profile. Both will work. E.g.

  • mvn clean install -Ppackage,jar-with-dependencies
  • mvn clean install -Ppackage -Djar.dependencies.skip=false

#21

@bmarwell bmarwell added the component:maven Changes to the java build process label Apr 14, 2019
@bmarwell bmarwell requested a review from tresf April 14, 2019 18:16
pom.xml Outdated Show resolved Hide resolved
@tresf
Copy link

tresf commented Apr 15, 2019

I find jar to be redundant all profiles produce a jar. I'd like simply with-dependencies if there are no objections.

@tresf
Copy link

tresf commented Apr 15, 2019

I find jar to be redundant all profiles produce a jar. I'd like simply with-dependencies if there are no objections.

Sorry, just realized this is a predefined property. Looks good!

@tresf
Copy link

tresf commented Apr 15, 2019

Just made a minor change to the variable name foo.bar.skip instead of skip.foo.bar to be consistent with our other variable names.

@tresf tresf merged commit ddd6165 into master Apr 15, 2019
@tresf tresf deleted the issues/21-fat-jar branch April 15, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:maven Changes to the java build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants