Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoist named shape logic from threefry's random_bits implementation #7709

Open
froystig opened this issue Aug 24, 2021 · 0 comments
Open

hoist named shape logic from threefry's random_bits implementation #7709

froystig opened this issue Aug 24, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request P2 (eventual) This ought to be addressed, but has no schedule at the moment. (Assignee optional)

Comments

@froystig
Copy link
Member

froystig commented Aug 24, 2021

The threefry2x32 PRNG's random_bits implementation handles named shapes by folding axis indices into the key. With #6899 in place, we should attempt to hoist this logic out of threefry and apply it uniformly across key implementations. In turn, hopefully RNG implementations need not be concerned about named shapes, only positional ones.

Related:

@froystig froystig added the enhancement New feature or request label Aug 24, 2021
@froystig froystig self-assigned this Aug 24, 2021
@froystig froystig changed the title hoist named axis key-folding logic from threefry's random_bits implementation hoist named shape logic from threefry's random_bits implementation Aug 24, 2021
@froystig froystig added the P2 (eventual) This ought to be addressed, but has no schedule at the moment. (Assignee optional) label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 (eventual) This ought to be addressed, but has no schedule at the moment. (Assignee optional)
Projects
None yet
Development

No branches or pull requests

1 participant