Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it necessary to get coverage of tests directory? #734

Open
sauravsharma1998 opened this issue Feb 28, 2024 · 3 comments
Open

Is it necessary to get coverage of tests directory? #734

sauravsharma1998 opened this issue Feb 28, 2024 · 3 comments
Labels

Comments

@sauravsharma1998
Copy link

Hi Everyone,

In the coverage you can observe that the tests directory is also showing the coverage. Is it intentional or something else?

image
@WisdomPill
Copy link
Member

makes sense to remove it, would like to make a PR for it?

@sauravsharma1998
Copy link
Author

sauravsharma1998 commented Feb 28, 2024

Hi @WisdomPill

Any suggestion for - Is it good to combined mypy report with code coverage?
As I have observed in previous commits that there are two possibilities

  1. With mypy report(Where code coverage is ~60%)
  2. Without mypy report(Where code coverage is ~90%)

Tried this one without tests directory for mypy command

Code Coverage is ~90%
https://app.codecov.io/gh/jazzband/django-redis/commit/526df6faf56f9a54f22c55b5f5f6a60276867d78/tree

@merwok
Copy link

merwok commented Dec 9, 2024

It is common to include tests in coverage, so that you can find unused functions for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants