Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters in the hero.clean() function to activate individual pre-processing steps #9

Closed
jbesomi opened this issue May 4, 2020 · 2 comments

Comments

@jbesomi
Copy link
Owner

jbesomi commented May 4, 2020

It would be cool to have parameters in the hero.clean() function to activate individual pre-processing steps instead of constructing a custom pipeline.

Proposal by @mxhofer

Notes: the solution should keep the clean function simple to read and use.

@selimelawwa
Copy link
Contributor

@jbesomi Would you suggest to add a **kwargs parameter to the clean function? or add some parameters with default value?

@jbesomi
Copy link
Owner Author

jbesomi commented Jul 8, 2020

Texthero's aim to be very simple. This enhancement would require to add many arguments to the clean function. Furthermore, in this case, the easiest solution would consist of just creating a custom pipeline: #38

@jbesomi jbesomi closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants