-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: default popupId
to useId
#128
Comments
I’m not sure there’s even a reason why you’d ever want to pass a non-generated id. |
Makes sense, I'll see if I can implement this soon, would also be open to a PR. I've generally used explicit IDs so that I can select the popup component in Selenium tests, though attaching data- attributes for test selectors would work too |
🎉 This issue has been resolved in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I would like to suggest a feature to default the
popupId
property to theuseId
hook when it has been omitted. The purpose of theuseId
hook is exactly for cases such as these, and it would cut down some boilerplate of always having to manually specifypopupId: useId()
every time.The text was updated successfully, but these errors were encountered: