Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): creates props for a component that opens the popup while double click #83

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

Holl9
Copy link
Contributor

@Holl9 Holl9 commented Nov 2, 2021

like useTrigger hook

@jedwards1211
Copy link
Member

cool thanks! Would you mind re-exporting this from index.js and hooks.js, and documenting it in the readme? (just mimic the way bindTrigger is mentioned in the readme)

@Holl9
Copy link
Contributor Author

Holl9 commented Nov 2, 2021

cool thanks! Would you mind re-exporting this from index.js and hooks.js, and documenting it in the readme? (just mimic the way bindTrigger is mentioned in the readme)

Ha ha, thank you. I just finished my work and added export and documents. good night

@Holl9
Copy link
Contributor Author

Holl9 commented Nov 2, 2021

cool thanks! Would you mind re-exporting this from index.js and hooks.js, and documenting it in the readme? (just mimic the way bindTrigger is mentioned in the readme)

By the way, dumi is recommended for component development documents。link:https://github.com/umijs/dumi

@jedwards1211 jedwards1211 merged commit ca579b4 into jcoreio:master Sep 22, 2022
@jedwards1211
Copy link
Member

sorry I completely forgot to merge this!

@jedwards1211
Copy link
Member

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants