Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Dialog #90

Closed
jacobjove opened this issue Jan 18, 2022 · 4 comments
Closed

Support for Dialog #90

jacobjove opened this issue Jan 18, 2022 · 4 comments
Labels
released

Comments

@jacobjove
Copy link

Thanks for this!
Could this library also support state for the MUI Dialog component (https://mui.com/components/dialogs/)?
@jacobjove
Copy link
Author

variant="popover" seems to play nicely with Dialog, actually.

@jedwards1211
Copy link
Member

Yeah sounds like that would basically work but it injects ARIA properties to the dialog that may not be appropriate for it. It would probably make sense to support variant="dialog", I'll look into it

@dohomi
Copy link

dohomi commented May 6, 2022

That would be a great addition to this library

@jedwards1211
Copy link
Member

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dohomi @jedwards1211 @jacobjove