Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more Packer builders #2

Open
xlr-8 opened this issue Jan 17, 2017 · 2 comments
Open

Add support for more Packer builders #2

xlr-8 opened this issue Jan 17, 2017 · 2 comments

Comments

@xlr-8
Copy link

xlr-8 commented Jan 17, 2017

Thanks for the project, really nice!

I was wondering if you thought of extending this project's scope? The project is called packer-resource, but manages "only" AMI from packer.

Would you consider adding other builders than AMI ?
If this was meant for AWS only, do you consider building docker images for ECR ?

Src: https://www.packer.io/docs/templates/builders.html

Best,

@jdub
Copy link
Owner

jdub commented Jan 17, 2017

Thanks -- I would definitely like to add non-AMI builders. I held off adding this to the community resources list because I thought it should work with multiple AMI outputs, non-AMI builders, etc. first.

@jdub jdub changed the title Make the resource more flexible Add support for more Packer builders Jan 26, 2017
@jdub
Copy link
Owner

jdub commented Jan 26, 2017

… and just over a week later, I have my own use case for a Docker builder. 😄

Some thoughts on the problem space:

  • We shouldn't break the current interface while adding other builders, e.g. the id file should remain for single AMI builds.
  • We should think carefully about the outputs based on what might consume them. The id file works very well as an input into cloudformation-resource. What might consume the output for X builder? What is the most useful output, or outputs?
  • We should handle multiple builders, so outputs should probably not step on each other.
  • When using multiple builders, it would be super helpful to let triggers choose one (or more?) builders. e.g. when your Packer git repo updates, you want to trigger every builder. But when your ami-resource updates, it'd be nice to trigger just the AMI builder. Saves having multiple packer resources, which would probably be copypasta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants