Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jeffbski/redux-logic
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.12.0
Choose a base ref
...
head repository: jeffbski/redux-logic
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Apr 18, 2017

  1. fix link in README

    jeffbski committed Apr 18, 2017
    Copy the full SHA
    7dc2dfa View commit details
  2. 0.12.1

    jeffbski committed Apr 18, 2017
    Copy the full SHA
    0726a77 View commit details

Commits on Apr 19, 2017

  1. Copy the full SHA
    b5de7f4 View commit details

Commits on Jul 16, 2017

  1. prevent hiding of errors occuring during a mw next call

    If an error is thrown during a middleware next call (in the downstream
    middleware, reducer, or renderer) then it could possibly be hidden,
    so this change logs it to console.error as well as the monitor$ to
    help with debugging.
    
    Because we are now catching errors during the next call, we also
    pick up those that happen in dispatch as well, so we don't need
    special handling for those, they all get picked up by nextError.
    
    Document the additional op when an error is detected (nextError).
    jeffbski committed Jul 16, 2017
    Copy the full SHA
    fe47b47 View commit details
  2. 0.12.2

    jeffbski committed Jul 16, 2017
    Copy the full SHA
    1d897c0 View commit details

Commits on Jul 27, 2017

  1. Copy the full SHA
    49a3ac1 View commit details

Commits on Aug 2, 2017

  1. Merge pull request #69 from cherniavskii/docs-cancellation-update

    Updated Cancellation section since axios supports request cancellation
    jeffbski authored Aug 2, 2017
    Copy the full SHA
    b5c2f7e View commit details

Commits on Aug 12, 2017

  1. Copy the full SHA
    c27fcc5 View commit details
  2. Copy the full SHA
    2b6bd78 View commit details

Commits on Sep 13, 2017

  1. Make rxjs a dependency

    To simplify use where a developer only wants to use redux-logic and
    doesn't plan to use observables directly, making rxjs a dependency
    allows redux-logic to be installed w/o manually installing rxjs first.
    
    It is still recommended to install rxjs first if Observables will
    directly be used in the project, so that multiple copies are not
    installed. A note was added to the readme.
    jeffbski committed Sep 13, 2017
    Copy the full SHA
    3b890b8 View commit details
  2. Copy the full SHA
    4830e8e View commit details
  3. Merge branch 'make-rxjs-dep'

    jeffbski committed Sep 13, 2017
    Copy the full SHA
    ba224af View commit details
  4. 0.12.3

    jeffbski committed Sep 13, 2017
    Copy the full SHA
    9b5bdc0 View commit details
  5. Update api.md

    Grammar
    Jeremaiha authored Sep 13, 2017
    Copy the full SHA
    b6dc6b4 View commit details
  6. Merge pull request #78 from Jeremaiha/patch-1

    Update api.md
    jeffbski authored Sep 13, 2017
    Copy the full SHA
    d8d6424 View commit details

Commits on Dec 15, 2017

  1. Copy the full SHA
    5a5b6a1 View commit details

Commits on Apr 5, 2018

  1. Export function to set 'createLogic' options globally

    Make a single call to the 'configureLogic' function to override the
    redux-logic library defaults for the following options:
    
      warnTimeout
    
    Closes #51
    sanbornhilland committed Apr 5, 2018
    Copy the full SHA
    1f51174 View commit details

Commits on May 7, 2018

  1. no decoration of intercept dispatches

    Intercept actions are not to be wrapped even if
    processOptions successType or failType are provided.
    Those options do not govern intercept actions.
    
    Added tests to ensure correctness.
    jeffbski committed May 7, 2018
    Copy the full SHA
    6b6743e View commit details
  2. Merge pull request #87 from cherniavskii/patch-1

    Fix transform anchor link in API docs
    jeffbski authored May 7, 2018
    Copy the full SHA
    149963d View commit details
  3. Copy the full SHA
    d9aa367 View commit details

Commits on May 8, 2018

  1. Copy the full SHA
    334bc30 View commit details
  2. 0.12.4

    jeffbski committed May 8, 2018
    Copy the full SHA
    207bc22 View commit details
  3. Merge pull request #89 from sanbornhilland/feature/global-timeouts

    Export function to set 'createLogic' options globally
    jeffbski authored May 8, 2018
    Copy the full SHA
    be56328 View commit details
  4. 0.13.0

    jeffbski committed May 8, 2018
    Copy the full SHA
    c37c644 View commit details

Commits on May 9, 2018

  1. update examples to use 0.13

    jeffbski committed May 9, 2018
    Copy the full SHA
    09863b9 View commit details

Commits on May 10, 2018

  1. Copy the full SHA
    29ffc28 View commit details
  2. Copy the full SHA
    8143606 View commit details

Commits on May 16, 2018

  1. Copy the full SHA
    9559df4 View commit details
  2. reverted formatting

    matthamil committed May 16, 2018
    Copy the full SHA
    6ceefdd View commit details

Commits on May 19, 2018

  1. add tests to support Symbol in createLogic.js

    add stringifyType utiltiy to support Symbol types in error messages and name definitions
    add tests for stringifyType utility
    a-marquez committed May 19, 2018
    Copy the full SHA
    2feb72c View commit details

Commits on Jun 13, 2018

  1. add test with many logic

    jeffbski committed Jun 13, 2018
    Copy the full SHA
    396233f View commit details
  2. cleanup whitespace

    jeffbski committed Jun 13, 2018
    Copy the full SHA
    22dd9d2 View commit details
  3. Copy the full SHA
    a05f6b8 View commit details

Commits on Jun 14, 2018

  1. Copy the full SHA
    53d3ee0 View commit details
  2. remove node@4 from travis

    latest code coverage plugin has issues running under Node v4. Removed
    since it is already past end of life.
    jeffbski committed Jun 14, 2018
    Copy the full SHA
    c405e50 View commit details
  3. 0.14.0

    jeffbski committed Jun 14, 2018
    Copy the full SHA
    ffd2857 View commit details
  4. Copy the full SHA
    865b8c8 View commit details
  5. Copy the full SHA
    49cfab7 View commit details
  6. Merge branch 'prevent-stringified-undefined' of https://github.com/ma…

    …tthamil/redux-logic into matthamil-prevent-stringified-undefined
    jeffbski committed Jun 14, 2018
    Copy the full SHA
    1d7cb4b View commit details
  7. 0.15.0

    jeffbski committed Jun 14, 2018
    Copy the full SHA
    7e287e8 View commit details
  8. Copy the full SHA
    11540e9 View commit details

Commits on Jul 12, 2018

  1. Copy the full SHA
    e3fc659 View commit details
  2. Copy the full SHA
    3d42c44 View commit details
  3. Copy the full SHA
    849417f View commit details

Commits on Aug 1, 2018

  1. support for redux@4.0.0+

    redux-logic will work fine with redux@4.0.0 as well as the
    older 3.5.x versions.
    
    peer dependency and dev dependency to support >=3.5.2 allowing
    the use of either.
    jeffbski committed Aug 1, 2018
    Copy the full SHA
    2533bab View commit details

Commits on Aug 2, 2018

  1. 0.15.1

    jeffbski committed Aug 2, 2018
    Copy the full SHA
    99d08f3 View commit details
  2. upgrade to rxjs@5.5.11

    jeffbski committed Aug 2, 2018
    Copy the full SHA
    4019b7a View commit details

Commits on Aug 6, 2018

  1. 0.15.2

    jeffbski committed Aug 6, 2018
    Copy the full SHA
    713462d View commit details
  2. Merge branch 'typescript' of https://github.com/alvis/redux-logic int…

    …o alvis-typescript
    
    typescript support added by Alvis HT Tang
    jeffbski committed Aug 6, 2018
    Copy the full SHA
    80a1d46 View commit details
  3. Copy the full SHA
    37edc1f View commit details
Showing 336 changed files with 21,553 additions and 12,604 deletions.
41 changes: 0 additions & 41 deletions .babelrc

This file was deleted.

6 changes: 6 additions & 0 deletions .browserslistrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Browsers and runtimes we support
# https://github.com/browserslist/browserslist
last 1 version
not dead
> 0.2%
# maintained node versions
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -5,4 +5,3 @@
**/node_modules/**
**/server.js
**/webpack.config*.js
**/examples/**
23 changes: 17 additions & 6 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
/* Also check test/.eslintrc for test specific config */
"root": true,
"extends": "airbnb-base",
"rules": {
"arrow-body-style": [1, "as-needed"],
@@ -8,28 +9,38 @@
"comma-dangle": 0,
"consistent-return": 1,
// causing issues with codacy
"default-param-last": 0,
"function-paren-newline": "off",
"import/no-unresolved": 0,
"indent": 0,
"implicit-arrow-linebreak": 0,
"max-len": "off",
"no-multi-spaces": 0,
"no-nested-ternary": 0,
"no-plusplus": 0,
"no-promise-executor-return": 0,
"no-shadow": 0,
// don't require functions to be declared before use
"no-use-before-define": [2, { "functions": false, "classes": true }],
// Disable until Flow supports let and const
"no-var": 0,
"no-undef": 0,
"no-unused-vars": 0,
"object-curly-newline": 0,
"object-curly-spacing": 0,
"object-property-newline": 0,
"operator-linebreak": 0,
"padded-blocks": 0,
"prefer-destructuring": 0,
"prefer-promise-reject-errors": 0,
"react/jsx-uses-react": 1,
"react/jsx-no-undef": 2,
"react/jsx-wrap-multilines": 2,
"switch-colon-spacing": 0,
"valid-jsdoc": 2
},
"parserOptions": {
"ecmaFeatures": {
"experimentalObjectRestSpread": true
}
"ecmaVersion": 9
},
"plugins": [
"react"
]
"plugins": ["react"]
}
6 changes: 6 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module.exports = {
tabWidth: 2,
singleQuote: true,
printWidth: 120,
trailingComma: 'none',
};
28 changes: 7 additions & 21 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,31 +1,17 @@
language: node_js
node_js:
- "4"
- "6"
- "7"
- '8'
- '10'
- '12'
- '14'
- node
script:
- npm run browserslist
- npm run check:src
- npm run dev-build
- npm run check:examples
- npm run test:cov-codacy
- npm run prod-build
- npm run build
branches:
except:
- experimental
cache:
directories:
- $HOME/.npm
- examples/async-rxjs-ajax-fetch/node_modules
- examples/async-fetch-vanilla/node_modules
- examples/async-fetch-proc-options/node_modules
- examples/async-rxjs-ajax-proc-options/node_modules
- examples/async-await/node_modules
- examples/async-await-proc-options/node_modules
- examples/countdown/node_modules
- examples/countdown-obs/node_modules
- examples/form-validation/node_modules
- examples/notification/node_modules
- examples/search-async-fetch/node_modules
- examples/single-file/node_modules
- examples/single-file-redux/node_modules
- $HOME/.npm
32 changes: 9 additions & 23 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -16,7 +16,6 @@ If you cannot find your answer in the README or the docs, please check the issue

[GitHub issue tracker for redux-logic](https://github.com/jeffbski/redux-logic/issues)


### Help Us Help You

On both websites, it is a good idea to structure your code and question in a way that is easy to read to entice people to answer it. For example, we encourage you to use syntax highlighting, indentation, and split text in paragraphs.
@@ -38,6 +37,7 @@ git clone https://github.com/your-username/redux-logic.git
#### Building redux-logic

Running the `build` task will create both a CommonJS module-per-module build and a UMD build.

```
npm run build
```
@@ -51,6 +51,7 @@ npm run build:lib
The result will be in the `lib` folder.

To create just a UMD build:

```
npm run build:umd
npm run build:umd:min
@@ -130,36 +131,21 @@ npm run docs:clean

### Examples

redux-logic comes with [official examples](http://jeffbski.github.io/redux-logic/docs/introduction/Examples.html) to demonstrate various concepts and best practices.

When adding a new example, please adhere to the style and format of the existing examples, and try to reuse as much code as possible. For example, `index.html`, `server.js`, and `webpack.config.js` can typically be reused.

#### Building and Testing the Examples

To build and test the official Redux examples, run the following:

```
npm run build:examples
npm run test:examples
```

Not all examples have tests. If you see an example project without tests, you are very welcome to add them in a way consistent with the examples that have tests.

Please visit the [Examples page](http://jeffbski.github.io/redux-logic/docs/introduction/Examples.html) for information on running individual examples.
redux-logic comes with [official examples](http://jeffbski.github.io/redux-logic-examples/docs/introduction/Examples.html) to demonstrate various concepts and best practices. These live in a separate repo [redux-logic-examples](https://github.com/jeffbski/redux-logic-examples)

### Sending a Pull Request

For non-trivial changes, please open an issue with a proposal for a new feature or refactoring before starting on the work. We don’t want you to waste your efforts on a pull request that we won’t want to accept.

On the other hand, sometimes the best way to start a conversation *is* to send a pull request. Use your best judgement!
On the other hand, sometimes the best way to start a conversation _is_ to send a pull request. Use your best judgement!

In general, the contribution workflow looks like this:

* Open a new issue in the [Issue tracker](https://github.com/jeffbski/redux-logic/issues).
* Fork the repo.
* Create a new feature branch based off the `master` branch.
* Make sure all tests pass and there are no linting errors.
* Submit a pull request, referencing any issues it addresses.
- Open a new issue in the [Issue tracker](https://github.com/jeffbski/redux-logic/issues).
- Fork the repo.
- Create a new feature branch based off the `master` branch.
- Make sure all tests pass and there are no linting errors.
- Submit a pull request, referencing any issues it addresses.

Please try to keep your pull request focused in scope and avoid including unrelated commits.

Loading