🐛 Fix MatchError bug with sealed trait -> open trait refactor #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmay
force-pushed
the
jeff/fix-match-error
branch
from
383d890 to
bd1a3c8
Compare
jeffmay
requested review from
darmbrus,
indra-rosadi-rally,
mingy711,
paul-a-kennedy-rally,
rajatkumar-agarwal and
virdis
jeffmay
force-pushed
the
jeff/fix-match-error
branch
from
bd1a3c8 to
8c0465c
Compare
mingy711
approved these changes
Oct 21, 2022
jeffmay
commented
Oct 21, 2022
| def unapply[A](fact: TypedFact[A]): Some[(FactType[A], A)] = fact match { | ||
| case SourceFactOfType(typeInfo, value) => Some((typeInfo, value)) | ||
| case DerivedFactOfType(typeInfo, value, _) => Some((typeInfo, value)) | ||
| } | ||
| def unapply[A](fact: TypedFact[A]): Some[(FactType[A], A)] = Some((fact.typeInfo, fact.value)) |
There was a problem hiding this comment.
I don't know why this wasn't a compiler error... TypeFact was not sealed...
There was a problem hiding this comment.
Hmm... it looks like the Scala compiler only checks for exhaustivity of sealed traits / classes. Removing the sealed qualifier broke the match statement AND simultaneously prevented the compiler from flagging it as an error... that kinda sucks. I feel like the compiler should always assume in-exhaustivity for any unsealed (i.e. open) type without a case _.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug with a
MatchErrorbeing thrown when using theFactorDerivedFactextractors on customFactsubclasses.Type of change
Checklist: