Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_edit_link contains pagination path #213

Closed
cmbuckley opened this issue Aug 24, 2021 · 2 comments · May be fixed by #219
Closed

github_edit_link contains pagination path #213

cmbuckley opened this issue Aug 24, 2021 · 2 comments · May be fixed by #219

Comments

@cmbuckley
Copy link
Contributor

cmbuckley commented Aug 24, 2021

If a page is paginated: true, all pages (except the first) contain the paginate_path in the github_edit_link.

I created a minimal demo here, but if you have the following config:

repository: "owner/repo"
paginate_path: "page/:num/"

and an index.html with paginated: true, then when you visit /page/2/ the github_edit_link will contain /page/2/index.html instead of just /index.html.

The issue here would seem to come from jekyll-paginate, because the page.path is set to /page/2/index.html. It seemed better to raise the issue here since that repo is not maintained.

cmbuckley added a commit to cmbuckley/cmbuckley.github.io that referenced this issue Aug 24, 2021
cmbuckley added a commit to cmbuckley/cmbuckley.github.io that referenced this issue Aug 24, 2021
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added stale and removed stale labels Oct 24, 2021
cmbuckley added a commit to cmbuckley/github-metadata that referenced this issue Dec 22, 2021
cmbuckley added a commit to cmbuckley/github-metadata that referenced this issue Dec 22, 2021
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyll jekyll locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@cmbuckley @jekyllbot and others