Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"twitter:creator" is set wrong with multiple users #221

Closed
mehmandarov opened this issue Jul 23, 2017 · 10 comments
Closed

"twitter:creator" is set wrong with multiple users #221

mehmandarov opened this issue Jul 23, 2017 · 10 comments

Comments

@mehmandarov
Copy link

When having several authors, <meta name="twitter:creator"...> gets set to "@username" (from _config.yml) and not "@author.twitter".

@mehmandarov
Copy link
Author

If that helps, I am still able to get the twitter user via: "{{author[page.author].twitter}}".

@benbalter
Copy link
Collaborator

benbalter commented Jul 24, 2017

@mehmandarov are you able to push up a failing test to reproduce this?

It should only use site.author if page.author (or page.authors.first) is empty

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@mehmandarov
Copy link
Author

@benbalter: I have a configuration that gives that error available online – both config and the running site. Not yet sure how to reproduce this in the tests as I need to set up the dev environment.

@jekyllbot jekyllbot removed the stale label Sep 24, 2017
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@benbrignell
Copy link

benbrignell commented Dec 16, 2017

I'm currently experiencing what I think this issue describes.

Here's some more information about what's happening.

Context:
I've set my global twitter username in config.yml. Each page on the site has a unique author/creator which in most cases is an actual name.

I'm seeing page.author being used by jekyll-seo-tag which in the majority of cases displays a non-valid twittername.

The issue with only use site.author if page.author (or page.authors.first) is empty referenced above is that page.author isn't ever empty and is rarely a twitter name.

Here's an example of my frontmatter:

layout: example
title: Mercedes-Benz Design Philosophy
author: Mercedes-Benz

Here's the resulting open graph data.


<meta name="twitter:card" content="summary" />
<meta name="twitter:site" content="@dsgnprinciples" />
<meta name="twitter:creator" content="@Mercedes-Benz" />

@Mercedes-Benz in this case is not a valid Twitter username.

It would be great to be able to either globally define twitter:creator for display when twitter:creator is not available, specify it where twitter:creator is available or if all else fails omit it where not available.

Thanks.

(For further context and to see a working example here's the repo if it's helpful https://github.com/benbrignell/principles.design)

@mehmandarov
Copy link
Author

Yes, this seems to be the same error, @benbrignell.

@benbalter
Copy link
Collaborator

It would be great to be able to either globally define twitter:creator for display when twitter:creator is not available, specify it where twitter:creator is available or if all else fails omit it where not available.

You can do this via front matter defaults, setting the default author twitter globally, and then overriding per post.

@benbrignell
Copy link

Thanks Ben, how would I override per post if only author is used (as above), when author is an actual name not a Twitter handle?

(If that makes sense)

@jekyll jekyll deleted a comment Jan 5, 2018
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyllbot jekyllbot added the stale label Mar 5, 2018
@jekyll jekyll locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants