-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
porecelain.add(files=None) adds files from root rather than os.getcwd() #521
Comments
Do you have some code that reproduces this? Dulwich has some tests for add without explicit paths specified and those pass. What platform are you on? |
Windows What I would like to use:
What is working for me at the moment:
|
Retrying now, still with I've checked for lockfiles, LF vs CRLF, closed my SourceTree instance. Everything seems fine. So most likely that this is an issue with my setup but just to confirm that the repo does not need to be closed after all other operations? I only run open_repo() then add() in my test. More important, other files are promoted too:
Is this expected? Is this again an issue with my setup? Thanks. |
Yes, there shouldn't be a need to reopn the repo after running add. What do you mean with "promoted" ? |
I do not reopen after add so this is fine. For promoted, I meant other files that are not modified/added by my script or files that Git usually ignores are moved to the staging area. For those under build/, it's the same content but all lines are replaced (.sh, .bat and .py files. The line endings are unchanged and OK). For those under out/ or temp/, these are new files created by script which get added. But they shouldn't. |
Dulwich currently doesn't support ignore files, files=None will add recursively from the repository root - not from the $PWD. That last bit should be easy to fix though. Does that match what you're seeing? |
Yes, it does behave as you describe. |
I've filed #524 about the lack of .gitignore support. The issue about recursing from $PWD is easy to fix, I'll change this bug to be about that. |
Hello,
Small issue with porcelain.add() not adding all modified/new files.
Tested with python 3.6 and dulwich (0.17.3), following syntax:
porcelain.get_tree_changes(base_repo) returns {'add': [], 'delete': [], 'modify': []} in this case.
Thanks in advance for your help.
The text was updated successfully, but these errors were encountered: