New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TB-218 OpenHIM Portal page shell #618

Merged

MatthewErispe merged 36 commits into poc-microfrontends from TB-218-open-him-portal-page-shell

Dec 8, 2023

Member

medchedli commented Oct 23, 2023 •

edited

Loading

These changes require updating the DB Schema. Check → jembi/openhim-core-js#1212

medchedli added 3 commits

October 19, 2023 18:06


          Rename pkg to match Single-SPA naming convention

fb10295


          Add initial implementation of OpenHIM Portal App

95d0cb1


          Add App to single-spa layout engine & activate it

5087fa1

medchedli changed the title ~~Tb 218 open him portal page shell~~ TB-218 OpenHIM Portal page shell

medchedli requested review from marrouchi and rcrichton

October 23, 2023 09:26

medchedli added 3 commits

October 23, 2023 16:17


          Remove husky from Portal App

fd2b4d6


          Code refactoring & add a form for adding new apps

60bc03d


          Remove unused imports

105f35d

nour-borgi reviewed

View reviewed changes

packages/portal-app/package.json Outdated Show resolved Hide resolved

medchedli added 8 commits

October 26, 2023 18:16


          move type definitions pkgs under devDependencies

80da541


          Rename Skeleton keys value

c049ec7


          Add an empty state for the portal home page

4fa21de


          Add a custom form component for registering apps

60dd649


          Update AddAppDialog component

90b6fd4


          Clean & lint code

7077c9f


          Update PortalHome layout

a2fd800


          Add whitespace auto-trimming to the user input

4628c72

MatthewErispe requested changes

View reviewed changes

packages/header-app/src/root.component.tsx Outdated Show resolved Hide resolved

packages/portal-app/src/components/AppCard/AppCard.tsx Outdated Show resolved Hide resolved

packages/portal-app/src/utils/apiClient.ts Outdated Show resolved Hide resolved


          Update react-dom version to match react version

bradsawadye reviewed

View reviewed changes

packages/header-app/src/root.component.tsx Outdated Show resolved Hide resolved

bradsawadye reviewed

View reviewed changes

packages/header-app/src/root.component.tsx Outdated Show resolved Hide resolved

bradsawadye reviewed

View reviewed changes

packages/header-app/src/root.component.tsx Outdated Show resolved Hide resolved

bradsawadye reviewed

View reviewed changes

packages/portal-app/.prettierignore Outdated Show resolved Hide resolved

bradsawadye reviewed

View reviewed changes

packages/portal-app/src/components/AddAppDialog/AddAppDialog.tsx Outdated Show resolved Hide resolved

medchedli added 5 commits

November 3, 2023 12:02


          Add react-hook-form package

8dcfb5f


          Add a custom Alert component

501f741


          Update EmptyState component

a109c89


          Add custom input fields components

ea321fb


          Refactor: rename components & add form validation

791c8c3


          style: apply linting

3748a1e

medchedli requested review from MatthewErispe and removed request for marrouchi

November 3, 2023 11:31

medchedli added 15 commits

November 6, 2023 18:29


          Update AddAppDialog

28a6535


          TB-234 add delete and edit apps

dbf5d06


          TB-273 Configure API base URL using .env file

757ce92


          Minor correction AppCard and EditAppDialog

4972be6


          Replacing Alerts with Snackbar using NotiStack

3a6e749


          Update AppCard

ed8384b


          Add missing update in webpack.config from 757ce92

d574d9c


          Add notistack to package.json missing in 3a6e749

1d28d92


          Change description field to non required

33e3853


          TB-220 Add conditional rendering for form fields

093868e


          update tsconfig

aeeb2b9


          Update page field to a required field

dfa045c


          Rename API Base URL env var

a7cddef


          Add dotenv-webpack to devDependencies

405f248


          Update PortalHome component to efficiently manage app state updates

bf5be77

brett-onions self-requested a review

November 10, 2023 15:46

medchedli marked this pull request as ready for review

December 1, 2023 07:44

MatthewErispe approved these changes

View reviewed changes

MatthewErispe merged commit c750eb8 into poc-microfrontends

0 of 2 checks passed

MatthewErispe deleted the TB-218-open-him-portal-page-shell branch

December 8, 2023 13:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nour-borgi nour-borgi left review comments

bradsawadye bradsawadye left review comments

MatthewErispe MatthewErispe approved these changes

rcrichton Awaiting requested review from rcrichton

brett-onions Awaiting requested review from brett-onions

Labels

None yet