-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT 638 Adjust login wih session and cookies #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @nour-borgi , left a couple of comments !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me. A few comments.
…mbi/openhim-core-js into PLAT-638-adjust-login-cookies-test-fix
…mbi/openhim-core-js into PLAT-638-adjust-login-cookies-test-fix
…mbi/openhim-core-js into PLAT-638-adjust-login-cookies-test-fix
…mbi/openhim-core-js into PLAT-638-adjust-login-cookies-test-fix
…mbi/openhim-core-js into PLAT-638-adjust-login-cookies-test-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on a quick scan, just one comment. I'l try go through and test it and give more feedback when I am able.
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: bradsawadye <[email protected]>
Co-authored-by: Michael Loosen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've tested this and all appears to work well. Just added a tiny comment.
…t-fix Plat 638 adjust login cookies test fix
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 85.08% 86.23% +1.14%
==========================================
Files 77 84 +7
Lines 5310 5716 +406
==========================================
+ Hits 4518 4929 +411
+ Misses 792 787 -5
... and 65 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
In this PR:
Now authentication can be done by either "basic" or "local" types.
"local" means through the UI with username and password, this will create a session and set cookies in the browser.
"basic" means with basic auth either through browser or postman by giving also username and password.
In Mongo, added passport and session tables to store auth info.