-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plat 719 fix user metadata importation #1189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable us to create users and their authentication passports through metadata importation PLAT-719
The email address of a user in now being used as the link between a user and their passport instead of the user's `_id`. The email is unique for each user, and is something that set where as the user id is created at the database level, and one would have to retrieve the user's id to link it a passport, which would make the metadata importation a bit complicated. Creating of a user and their passport can now be done at the same time as one no longer needs the user's email for linking it to a passport. PLAT-719
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 86.44% 86.46% +0.01%
==========================================
Files 85 85
Lines 5800 5798 -2
==========================================
- Hits 5014 5013 -1
+ Misses 786 785 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Adjust the metadata logic to enable importation of users' authentication passports PLAT-719
This field is now required
nour-borgi
previously approved these changes
Apr 14, 2023
nour-borgi
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.