Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat 719 fix user metadata importation #1189

Merged
merged 7 commits into from
Apr 24, 2023

Conversation

bradsawadye
Copy link
Contributor

No description provided.

This will enable us to create users and their authentication passports through metadata importation

PLAT-719
The email address of a user in now being used as the link between a user and their passport instead of the user's `_id`. The email is unique for each user, and is something that set where as the user id is created at the database level, and one would have to retrieve the user's id to link it a passport, which would make the metadata importation a bit complicated. Creating of a user and their passport can now be done at the same time as one no longer needs the user's email for linking it to a passport.

PLAT-719
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1189 (2e193b2) into master (307172f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2e193b2 differs from pull request most recent head 5e6a793. Consider uploading reports for the commit 5e6a793 to get more accurate results

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   86.44%   86.46%   +0.01%     
==========================================
  Files          85       85              
  Lines        5800     5798       -2     
==========================================
- Hits         5014     5013       -1     
+ Misses        786      785       -1     
Impacted Files Coverage Δ
src/api/users.js 93.36% <ø> (ø)
src/model/passport.js 91.30% <ø> (-8.70%) ⬇️
src/model/users.js 100.00% <ø> (ø)
src/protocols/local.js 100.00% <ø> (ø)
src/protocols/openid.js 100.00% <ø> (ø)
src/protocols/token.js 100.00% <ø> (ø)
src/upgradeDB.js 82.31% <ø> (ø)
src/api/metadata.js 93.57% <100.00%> (+2.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bradsawadye and others added 3 commits April 14, 2023 08:58
Adjust the metadata logic to enable importation of users' authentication passports

PLAT-719
This field is now required
nour-borgi
nour-borgi previously approved these changes Apr 14, 2023
@nour-borgi nour-borgi merged commit 4de09d4 into master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants