feat: add docker support for arm64 platform #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
- Coverage 86.47% 86.46% -0.02%
==========================================
Files 85 85
Lines 5798 5798
==========================================
- Hits 5014 5013 -1
- Misses 784 785 +1 |
bradsawadye
previously approved these changes
Apr 18, 2023
rcrichton
previously approved these changes
Apr 18, 2023
nour-borgi
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Failed to fetch docker image for MacOS (missing M1 arm64 platform build).
Github action config was updated according to docker documentation to publish multi-platform images :
https://docs.docker.com/build/ci/github-actions/multi-platform/
Related PRs : jembi/openhim-console#607