Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Openid connect provider issuer url to config and update passport.js to use it #1215

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

rcrichton
Copy link
Member

This pull request adds the ability to specify an optional Openid connect provider issuer url in the config file. If provided, passport.js will use this url instead of the api url. This change ensures that the correct issuer url is used when using a proxy.

config and update passport.js to use it.
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b9a686) 86.76% compared to head (c5f8cbb) 86.76%.

❗ Current head c5f8cbb differs from pull request most recent head 0e6267b. Consider uploading reports for the commit 0e6267b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          89       89           
  Lines        6024     6024           
=======================================
  Hits         5227     5227           
  Misses        797      797           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcrichton rcrichton merged commit c9eceb2 into master Nov 16, 2023
4 checks passed
@rcrichton rcrichton deleted the sso-issuer-fix branch November 16, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants