Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete for VM sizes #580

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

timja
Copy link
Member

@timja timja commented Nov 11, 2024

Requires jenkinsci/jenkins#9959

Previously:

image

On click giant dropdown:
image

Now:

image

I want to view D4a's:

image

D series:
image

Testing done

Tried various options with filtering to make sure it makes sense. I initially tried combo-box but it didn't give me control over the filtering / searching which was a bit of a pain with the standard/basic prefix and also with just wanting to search e.g D4 and getting sensible results. Autocomplete allowed more power.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant