-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modern UI plugins, checks-api, update junit, remove 2.176.x & 2.190.x #338
Conversation
weird the tests that failed are for 2.249.x 2.249.x uses jackson2-api-plugin 2.11.3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for the checks-api part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with dropping old baselines. We are in the experimental mode, so even keeping one latest LTS is OKish. API libs is a good step towards future JUnit and Warnings Ng alignment. Approved if it works.
the README says a few, we're currently keeping a lot more than a few 😂 |
Still have some problems with |
I am OK with removing the old lines at this point. Would want to do one last release with the current updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Not sure why PCT is downgrading jackson-api in those plugins when they clearly have a higher dep in their pom.xml
Reproducible easily via PLUGINS=ssh-credentials TEST=InjectedTest bash local-test.sh The problem is with I suspect the nonstandard reactor design in |
😢 the problem is test jars can't bring in dependencies on other libraries, and the test harness is pulling in a json schema validator |
Now there are other problems, e.g.
Not exactly sure what is going on here, but it looks like PCT will need to be patched somehow. |
Going to see if #341 removes the blockers for this. |
🎉 |
Most of the new plugins baseline is 2.204.x, checks-api was never available on an old baseline, and all the others would need backporting, would be an absolute nightmare (this was already a pain to get all these plugins working properly).
So let's drop old baselines...
🙏 CI works across all of these