Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modern UI plugins, checks-api, update junit, remove 2.176.x & 2.190.x #338

Merged
merged 9 commits into from
Oct 26, 2020

Conversation

timja
Copy link
Member

@timja timja commented Oct 21, 2020

Most of the new plugins baseline is 2.204.x, checks-api was never available on an old baseline, and all the others would need backporting, would be an absolute nightmare (this was already a pain to get all these plugins working properly).

So let's drop old baselines...

🙏 CI works across all of these

@timja
Copy link
Member Author

timja commented Oct 21, 2020

weird the tests that failed are for 2.249.x

image

2.249.x uses jackson2-api-plugin 2.11.3

Caused by: java.io.IOException: Failed to load: JUnit Plugin (1.41)
 - Update required: Jackson 2 API Plugin (2.11.1) to be updated to 2.11.3 or higher
	at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:952)
	at hudson.PluginManager$2$1$1.run(PluginManager.java:549)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)
	at jenkins.model.Jenkins$5.runTask(Jenkins.java:1131)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	... 3 more
SEVERE: Failed Loading plugin ECharts API Plugin v4.9.0-2 (echarts-api)
java.io.IOException: Failed to load: ECharts API Plugin (4.9.0-2)
 - Update required: Jackson 2 API Plugin (2.11.0) to be updated to 2.11.1 or higher
	at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:952)
	at hudson.PluginManager$2$1$1.run(PluginManager.java:549)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)
	at jenkins.model.Jenkins$5.runTask(Jenkins.java:1131)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Copy link

@XiongKezhi XiongKezhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the checks-api part

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with dropping old baselines. We are in the experimental mode, so even keeping one latest LTS is OKish. API libs is a good step towards future JUnit and Warnings Ng alignment. Approved if it works.

@timja
Copy link
Member Author

timja commented Oct 21, 2020

I am fine with dropping old baselines. We are in the experimental mode, so even keeping one latest LTS is OKish. API libs is a good step towards future JUnit and Warnings Ng alignment. Approved if it works.

the README says a few, we're currently keeping a lot more than a few 😂

@jglick jglick changed the title Add modern UI plugins, checks-api, update junit, remove old lines Add modern UI plugins, checks-api, update junit, remove 2.176.x & 2.190.x Oct 21, 2020
@jglick jglick added dependencies Pull requests that update a dependency file enhancement New feature or request removed labels Oct 21, 2020
@jglick
Copy link
Member

jglick commented Oct 21, 2020

Still have some problems with jackson2-api.

@jglick
Copy link
Member

jglick commented Oct 21, 2020

I am OK with removing the old lines at this point. Would want to do one last release with the current updates.

Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure why PCT is downgrading jackson-api in those plugins when they clearly have a higher dep in their pom.xml

@jglick
Copy link
Member

jglick commented Oct 23, 2020

Reproducible easily via

PLUGINS=ssh-credentials TEST=InjectedTest bash local-test.sh

The problem is with io.jenkins.configuration-as-code:test-harness as usual; it is pulling in an older version of jackson2-api. PCT is not prepared for this I guess.

I suspect the nonstandard reactor design in configuration-as-code-plugin is responsible for numerous problems. Other plugins just have a test JAR. Here we have a separate jar-packaging artifact with a dependency on a plugin and it seems it is a mess.

@timja
Copy link
Member Author

timja commented Oct 23, 2020

Reproducible easily via

PLUGINS=ssh-credentials TEST=InjectedTest bash local-test.sh

The problem is with io.jenkins.configuration-as-code:test-harness as usual; it is pulling in an older version of jackson2-api. PCT is not prepared for this I guess.

I suspect the nonstandard reactor design in configuration-as-code-plugin is responsible for numerous problems. Other plugins just have a test JAR. Here we have a separate jar-packaging artifact with a dependency on a plugin and it seems it is a mess.

😢 the problem is test jars can't bring in dependencies on other libraries, and the test harness is pulling in a json schema validator

@jglick jglick marked this pull request as draft October 23, 2020 21:55
@jglick
Copy link
Member

jglick commented Oct 23, 2020

Now there are other problems, e.g. InjectedTest for git-client

ECharts API Plugin version 4.9.0-2 failed to load.
 - Jackson 2 API Plugin version 2.11.0 is older than required. To fix, install version 2.11.1 or later.

Not exactly sure what is going on here, but it looks like PCT will need to be patched somehow.

@jglick
Copy link
Member

jglick commented Oct 25, 2020

Going to see if #341 removes the blockers for this.

@jglick jglick marked this pull request as ready for review October 25, 2020 22:30
bom-latest/pom.xml Outdated Show resolved Hide resolved
@jglick
Copy link
Member

jglick commented Oct 26, 2020

🎉

@jglick jglick merged commit f2686ea into jenkinsci:master Oct 26, 2020
@jetersen jetersen deleted the echarts branch October 26, 2020 15:45
@jglick
Copy link
Member

jglick commented Oct 30, 2020

https://github.com/jenkinsci/bom/releases/tag/bom-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants