Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Throttle Concurrent Builds to the managed set #471

Merged
merged 4 commits into from
Jun 13, 2021

Conversation

basil
Copy link
Member

@basil basil commented Mar 25, 2021

Although this plugin is not used as a dependency very often, I think it would be desirable to have it included in the BOM inasmuch as this results in increased compatibility testing.

@basil basil marked this pull request as ready for review June 12, 2021 20:33
@timja timja enabled auto-merge (squash) June 13, 2021 08:01
@timja timja added the chore Reduces future maintenance label Jun 13, 2021
@timja timja merged commit c38dcf4 into jenkinsci:master Jun 13, 2021
@timja
Copy link
Member

timja commented Jun 13, 2021

hmm, this failed on master https://github.com/jenkinsci/bom/runs/2813164559

@basil
Copy link
Member Author

basil commented Jun 13, 2021

That test passes locally with PLUGINS=throttle-concurrents TEST=hudson.plugins.throttleconcurrents.ThrottleJobPropertyFreestyleTest bash local-test.sh. I think it's just flaky. Let me see if I can debug it.

@basil
Copy link
Member Author

basil commented Jun 13, 2021

That test passes locally with PLUGINS=throttle-concurrents TEST=hudson.plugins.throttleconcurrents.ThrottleJobPropertyFreestyleTest bash local-test.sh. I think it's just flaky. Let me see if I can debug it.

=> jenkinsci/throttle-concurrent-builds-plugin#130

I'll release that and then open a PR to update Throttle Concurrent Builds in the BOM to the new version where the flaky test is fixed.

@basil basil deleted the throttle-concurrents branch June 13, 2021 18:24
@basil
Copy link
Member Author

basil commented Jun 13, 2021

I'll release that and then open a PR to update Throttle Concurrent Builds in the BOM to the new version where the flaky test is fixed.

=> #555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants