Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73613] refresh buildhistory widget in all cases #9624

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Aug 16, 2024

refresh the buildHistory widget instantly when the window gets focus, e.g. after switching browser tabs but also when one was in another application and clicks in the browser window.
When the window is visible it will update even when it has no focus, when the window is hidden no calls to the controller will be done.

Additionally the buildHistory will be updated when it is not on the first page. So e.g. when someone deletes a build, changes the display name or the description or when a build is still running the page gets updated.

This replaces #9605

See JENKINS-73613.
See JENKINS-73592.

Testing done

Manual testing

  • Create a job and run it at least once

  • From dashboard view open the job in a new tab

  • switch to tab -> the history should load instantly

  • make the job run for longer time and start it once (sleep 300)

  • reconfigure the job to do nothing

  • run the job over 30 times until the long running build is on the second page of the history

  • go to second page of history and see that the still running build gets updated and finally finishes

  • in another browser window delete a build from the second page -> build is removed

  • in another browser window, change the display name and/or description of a build-> name/description changes

Proposed changelog entries

  • Refresh build history widget in all cases, including on background tabs or hidden tabs.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

refresh the buildHistory widget instantly when the window gets focus,
e.g. after switching browser tabs but also when one was in another
application and clicks in the browser window.
When the window is visible it will update even when it has no focus,
when the window is hidden no calls to the controller will be done.

Additionally the buildHistory will be updated when it is not on the
first page. So e.g. when someone deletes a build, changes the display
name or the description or when a build is still running the page gets
updated.
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@timja timja added the bug For changelog: Minor bug. Will be listed after features label Aug 20, 2024
@timja
Copy link
Member

timja commented Aug 20, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 20, 2024
@NotMyFault NotMyFault merged commit 83541cf into jenkinsci:master Aug 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants