fix JENKINS-69410: Links to Attached Artifacts broken #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olamy , @aheritier , @bguerin , @alvarolobato - could one of you please have a look to this? The current check build job did fail with Could not transfer artifact com.thoughtworks.xstream:xstream:jar:1.4.20 from/to azure-internal (http://artifact-caching-proxy.privatelink.azurecr.io:8080/): status code: 403, reason phrase: Forbidden (403) |
|
Hello Thanks for the PR, I will look at it this week-end |
|
unit tests fixed, I will look at the build error, seems it is time to switch baseline ... |
bguerin
force-pushed
the
JENKINS-69410
branch
from
4dc42c3
to
c606f9a
Compare
- pipeline-maven:
- pipeline/maven/util/XmlUtils.java:
- add missing attachedMavenArtifact.setVersion(version from deployed artifact)
- pipeline-maven-api:
- pipeline/maven/MavenArtifact.java:
- avoid double // in deployed artifact URL
if deploy repository URL ends with /
bguerin
force-pushed
the
JENKINS-69410
branch
from
c606f9a
to
44ad42b
Compare
bguerin
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
e.g. -sources.jar artifacts attached by the Maven sources plugin do not get proper links in case the deploy plugin will create time stamped filenames deployed (which is the most common usage for deployed snapshot artifacts).
/character, then the deployed artifact URL link is containing a//. This issue is fixed by this PR as well.Root cause
s. details in the commit comment
Testing done
This has been tested manually for a couple of more or less complex multi module Maven projects with a couple of our companies product specific file types attached.
Existing unit tests did not have been updated yet with this PR since of time constraints.
@bguerin If you could help by giving some hint what test files and unit tests to focus on for an update, maybe I can find some time to cover this.
Submitter checklist