Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Java 11 to Java 17 for test environment #487

Conversation

alecharp
Copy link
Member

@alecharp alecharp commented May 29, 2024

Testing done

When running with Java 17 and a Jenkins Core built with -Dmaven.compiler.target=17 tests are failing. This resolves the problem.
As Jenkins will be compiled with such option in just 20days, this is providing from prevention.
As you can see from this pull request build result, there is no problem with the current core requirement and those changes.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@alecharp alecharp marked this pull request as ready for review May 30, 2024 08:47
@alecharp alecharp requested a review from a team as a code owner May 30, 2024 08:47
@kuisathaverat kuisathaverat merged commit 6f8823c into jenkinsci:main May 30, 2024
14 checks passed
@alecharp
Copy link
Member Author

Thank you @kuisathaverat. As before, this will need to be released so the different testing environment can use the version.

@kuisathaverat
Copy link
Contributor

@alecharp Do test changes need a release? I do not think so; the tests are not included in the binary.

@alecharp
Copy link
Member Author

True, still they are used during PCT which will be broken until this patch is released.
As there is no changes in production files, releasing this patch is "risk-free" for the users.

@alecharp alecharp deleted the chore/update-test-environment-for-java-17 branch May 30, 2024 11:24
@kuisathaverat
Copy link
Contributor

@basil
Copy link
Member

basil commented May 30, 2024

Indeed, https://github.com/jenkinsci/plugin-compat-tester works by cloning the tests for the repository at a particular release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants