Do not save a GString as Keyword.value
#312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jglick! |
|
@steven-terrana Is it possible to do a release with this change. Our test pipline crashes with this error. The Cloudbees team recommends this fix for us. If a release is available, I will do a test and give feedback if the patch will fix our problem. |
|
If you have a reproducible test case, I would suggest actually trying a build of this PR (or currently plugin trunk) to confirm whether it resolves the issue. You do not need a release. (Since this plugin is Gradle-based, there is no incrementals link, so you would need to build it locally.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might solve #311, just based on the stack trace. Or might not, or might cause other problems, or fix this one only to have the next JEP-200 violation break. Totally untested, YMMV.