Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for electron-positioner #57354

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Add types for electron-positioner #57354

merged 1 commit into from
Nov 25, 2021

Conversation

ktmouk
Copy link
Contributor

@ktmouk ktmouk commented Nov 24, 2021 •
edited
Loading

Fixed: jenslind/electron-positioner#15

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 24, 2021 •
edited
Loading

@ktmouk Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 57354,
  "author": "ktmouk",
  "headCommitOid": "efa996191f6324ea4bf50eaea1312f9bf24896fd",
  "lastPushDate": "2021-11-24T14:51:04.000Z",
  "lastActivityDate": "2021-11-24T14:51:04.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "electron-positioner",
      "kind": "add",
      "files": [
        {
          "path": "types/electron-positioner/electron-positioner-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/electron-positioner/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/electron-positioner/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/electron-positioner/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/electron-positioner/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "ktmouk"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 977942526,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Check Config Changes a module config files labels Nov 24, 2021
@typescript-bot
Copy link
Contributor

🔔 @ktmouk — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@ktmouk ktmouk force-pushed the electron-positioner branch from 7611bdd to efa9961 Compare November 24, 2021 14:51
@typescript-bot typescript-bot removed the Check Config Changes a module config files label Nov 24, 2021
gabritto
gabritto approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! ✨

@gabritto gabritto merged commit ace21f3 into DefinitelyTyped:master Nov 25, 2021
@ktmouk ktmouk deleted the electron-positioner branch November 26, 2021 10:18
@ktmouk ktmouk mentioned this pull request Nov 26, 2021
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabritto gabritto gabritto approved these changes

Assignees
No one assigned
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript typings
3 participants
@ktmouk @typescript-bot @gabritto