From 7c9ec532d2072921bec554eb2b876ce3cbaa3d85 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Fri, 27 Nov 2020 10:54:15 +0100 Subject: [PATCH 1/4] Add truffleruby-head to CI --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4ae86c0e26..79a3df7937 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,7 +24,7 @@ jobs: strategy: fail-fast: false matrix: - ruby: [ 2.4, 2.5, 2.6, 2.7, jruby-9.1.17.0, jruby-9.2.13.0 ] + ruby: [ 2.4, 2.5, 2.6, 2.7, jruby-9.1.17.0, jruby-9.2.13.0, truffleruby-head ] name: ${{ matrix.ruby }} env: BUNDLE_GEMFILE: .ci.gemfile From 1f42c1d153d340763f6e7476a53e96f1f552e633 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Fri, 27 Nov 2020 11:32:39 +0100 Subject: [PATCH 2/4] TruffleRuby needs a system libxml2/libxslt --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 79a3df7937..f815a0822c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,6 +31,8 @@ jobs: steps: - uses: actions/checkout@v2 - run: sudo apt-get -yqq install libpq-dev mysql-client libmysqlclient-dev + - run: sudo apt-get -yqq install libxml2-dev libxslt-dev + if: startsWith(matrix.ruby, 'truffleruby') - uses: ruby/setup-ruby@v1 with: ruby-version: ${{ matrix.ruby }} From 942bb873b24d77d388bf9addb3a908254b9fda68 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Mon, 30 Nov 2020 21:40:28 +0100 Subject: [PATCH 3/4] Use continue-on-error at the job level --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f815a0822c..36739f0d8e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,7 @@ jobs: name: ${{ matrix.ruby }} env: BUNDLE_GEMFILE: .ci.gemfile + continue-on-error: ${{ startsWith(matrix.ruby, 'truffleruby') }} steps: - uses: actions/checkout@v2 - run: sudo apt-get -yqq install libpq-dev mysql-client libmysqlclient-dev From 0f92913ed8489a178db58c7239219f26d96be025 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Fri, 4 Dec 2020 14:12:51 +0100 Subject: [PATCH 4/4] Move to step-level continue-on-error * continue-on-error is confusing on PRs and it looks like CI failed even though it was an expected failure. See https://github.com/actions/toolkit/issues/399#issuecomment-738700569 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 36739f0d8e..01fe1bf534 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,6 @@ jobs: name: ${{ matrix.ruby }} env: BUNDLE_GEMFILE: .ci.gemfile - continue-on-error: ${{ startsWith(matrix.ruby, 'truffleruby') }} steps: - uses: actions/checkout@v2 - run: sudo apt-get -yqq install libpq-dev mysql-client libmysqlclient-dev @@ -42,3 +41,4 @@ jobs: env: DEFAULT_DATABASE: 1 MYSQL_ROOT_PASSWORD: 1 + continue-on-error: ${{ startsWith(matrix.ruby, 'truffleruby') }}