Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podfiles support #1187

Closed
Kollerb04 opened this issue Apr 6, 2018 · 9 comments
Closed

Podfiles support #1187

Kollerb04 opened this issue Apr 6, 2018 · 9 comments

Comments

@Kollerb04
Copy link

I'm running jenkins plugin ananalyzer and publisher version 3.1.2 for an iOS project. It takes a couple of minutes to run:
dependencyCheckAnalyzer datadir: '', hintsFile: '', includeCsvReports: false, includeHtmlReports: true, includeJsonReports: false, includeVulnReports: true, isAutoupdateDisabled: false, outdir: '', scanpath: '', skipOnScmChange: false, skipOnUpstreamChange: false, suppressionFile: '', zipExtensions: '' dependencyCheckPublisher canComputeNew: false, defaultEncoding: '', healthy: '', pattern: '', unHealthy: ''
It produces a dependency-check-data folder with dc.h2.db with approx 320mb of size and a dependency-check-report.xml. It also updates jenkins job summary page saying that 0 warnings were found.
The output of the jenkins job is:
[DependencyCheck] OWASP Dependency-Check Plugin v3.1.2 [DependencyCheck] Executing Dependency-Check with the following options: [DependencyCheck] -name = myjob [DependencyCheck] -scanPath = /mypath/ [DependencyCheck] -outputDirectory = /mypath/ [DependencyCheck] -dataDirectory = /mypath//dependency-check-data [DependencyCheck] -dataMirroringType = none [DependencyCheck] -isQuickQueryTimestampEnabled = true [DependencyCheck] -jarAnalyzerEnabled = true [DependencyCheck] -nodePackageAnalyzerEnabled = true [DependencyCheck] -nspAnalyzerEnabled = true [DependencyCheck] -composerLockAnalyzerEnabled = true [DependencyCheck] -pythonDistributionAnalyzerEnabled = true [DependencyCheck] -pythonPackageAnalyzerEnabled = true [DependencyCheck] -rubyBundlerAuditAnalyzerEnabled = false [DependencyCheck] -rubyGemAnalyzerEnabled = true [DependencyCheck] -cocoaPodsAnalyzerEnabled = true [DependencyCheck] -swiftPackageManagerAnalyzerEnabled = true [DependencyCheck] -archiveAnalyzerEnabled = true [DependencyCheck] -assemblyAnalyzerEnabled = true [DependencyCheck] -centralAnalyzerEnabled = true [DependencyCheck] -nuspecAnalyzerEnabled = true [DependencyCheck] -nexusAnalyzerEnabled = false [DependencyCheck] -autoconfAnalyzerEnabled = true [DependencyCheck] -cmakeAnalyzerEnabled = true [DependencyCheck] -opensslAnalyzerEnabled = true [DependencyCheck] -showEvidence = true [DependencyCheck] -formats = XML HTML VULN [DependencyCheck] -autoUpdate = true [DependencyCheck] -updateOnly = false [DependencyCheck] Scanning: /mypath/ [DependencyCheck] Analyzing Dependencies [Pipeline] dependencyCheckPublisher [DependencyCheck] Collecting Dependency-Check analysis files... [DependencyCheck] Searching for all files in /mypath/ that match the pattern **/dependency-check-report.xml [DependencyCheck] Parsing 1 file in /mypath/ [DependencyCheck] Successfully parsed file /mypath//dependency-check-report.xml with 0 unique warnings and 0 duplicates.
That output takes around 3.30 minutes to finish.

Why is that happenning? I find it unbelieveable that it didn't find at least a one warning.

@stevespringett
Copy link
Collaborator

Dependency-Check supports CocoaPods and the Swift Package Manager.

Are you using one of these package managers or are your dependencies part of the repo?

@Kollerb04
Copy link
Author

Kollerb04 commented Apr 9, 2018

Cocoa yes, swift package manager no, dependencies part of the repo probably not.

@stevespringett
Copy link
Collaborator

One way to check would be to specify a dependency on a pod that has known vulnerabilities.

Try temporarily adding https://cocoapods.org/?q=openssl to test. All versions of this pod are vulnerable and no versions of the pod are available that are not vulnerable.

Dependency-Check should find this issue. Please report back if you could.

See also: https://www.sourceclear.com/vulnerability-database/libraries/openssl-osx/objective-c/cocoapods/lid-783023

@ndurell
Copy link

ndurell commented Apr 11, 2018

I believe I'm having a similar issue. I tried adding openssl to my project and it did not come up in the list of dependencies.
This is the command I ran:
dependency-check --enableExperimental --project Notarize --out . --scan notarize-ios
Is the expectation that I can run this tool on my iOS app or a cocoapod library that specifies a podspec file? I notice in your documentation that the tool looks for podspec. In our project we have Podfiles that list the dependencies.
Sorry to jump on this issue I can open a separate one if needed.

@Kollerb04
Copy link
Author

@stevespringett the OpenSSL-OSX doesn't seem to be compatible with the ios platform

@jeremylong
Copy link
Owner

@ndurell Correct - atm ODC does not support podfiles.

@Kollerb04 does your application have podfiles or podspec files?

@Kollerb04
Copy link
Author

Kollerb04 commented Apr 16, 2018

@jeremylong yes it uses podfiles
And yes, just tried it on Android and that worked. So if podfiles are not supported and theres nothing that can be done about it then I consider this solved

@jeremylong
Copy link
Owner

I am going to convert this to an enhancement request to support podfiles.

@jeremylong jeremylong changed the title Scan produces no warnings at all Podfiles support Apr 16, 2018
@lock
Copy link

lock bot commented Sep 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants