Filter out the reactorprojects in the dependencies for the MSHARED-998 workaround attempting to resolve a dependency with a classifier #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the DependencyResolverException
…lassifiers to avoid issue #3730
…he actual exception location; restore initializing from ex, but only add exceptions from ex when an exCol was already non-null
|
As indicated in the issue this does not resolve all failure cases yet... converting to draft PR for further working |
|
@aikebah let me know when this is ready and we'll push another release. |
…itive dependencies via reactor projects as per #3730 (comment)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| private Mshared998Util() { | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Reporter: Checkstyle
Rule: com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck
Severity: ERROR
File: maven/src/main/java/org/owasp/dependencycheck/maven/Mshared998Util.java L37
First sentence should end with a period.
|
@jeremylong if this branch also passes the project setup of @viktor-thell-seal I would consider it final |
|
@jeremylong it's ready for review/merge |
jeremylong
reviewed
Oct 23, 2021
maven/src/main/java/org/owasp/dependencycheck/maven/Mshared998Util.java
Outdated
Show resolved
Hide resolved
jeremylong
approved these changes
Oct 23, 2021
|
Thanks for all the work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #3730
Description of Change
Remove the reactorProjects from the dependencies offered to the ArtifactResolver when trying to resolve dependencies with classifiers in the work-around for MSHARED-998
Have test cases been added to cover the new functionality?
yes, a test-case similar to the project in the issue has been added to the integration-tests to avoid a regression in the future