Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task formatKotlin should fail build if it cannot fix all lint errors #347

Closed
acreddy9 opened this issue Oct 19, 2023 · 3 comments
Closed

Comments

@acreddy9
Copy link
Contributor

acreddy9 commented Oct 19, 2023

This issue is the inverse of issue #335.

It is slightly misleading when the formatKotlin task build succeeds with unfixed lint errors. This can be solved by adding an optional configuration so users can choose whether the formatKotlin task build succeeds (default) or fails when it is unable to autoformat all lint errors detected. The configuration should be overrided by the ignoreFailures configuration, such that if ignoreFailures is set to true then the build will always succeed. We actually have this solution ready and can make a PR, but wanted to open this issue first to provide an explanation and receive any initial feedback :)

@juliakispert
Copy link

We would love any feedback on the PR or issue. Thank you in advance!

@jeremymailen
Copy link
Owner

jeremymailen commented Nov 5, 2023

Sorry about the delay. It's been extraordinarily busy this past month. I do plan to get the pending changes reviewed and a new version out, but it might be a few days before I can get to it.

@jeremymailen
Copy link
Owner

Will incorporate into 4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants