Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _javascript_1 file icon to seti icon theme for test.mjs #697

Closed
desean1625 opened this issue Apr 15, 2024 · 1 comment · Fixed by #701
Closed

Add _javascript_1 file icon to seti icon theme for test.mjs #697

desean1625 opened this issue Apr 15, 2024 · 1 comment · Fixed by #701

Comments

@desean1625
Copy link

Can we add test.mjs extension to seti icon theme?

This file extension is the default for node js test runner.

It would be nice to have the same theming as the regular javascript for javascript modules.

microsoft/vscode#210245

@gian1200
Copy link
Contributor

gian1200 commented Jul 18, 2024

Not only test.mjs, but add .mjs to all rules that have .js

.icon-set(".js", "javascript", @yellow);

Also special cases such as .spec.mjs, .test.mjs, stylelint.config.mjs, .eslintrc.mjs, new eslint.config.mjs flat config file, karma.conf.cjs, karma.conf.mjs, webpack.{config,dev,prod,common}.mjs, etc.

Update:
there is already a PR for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants