feat(rules): add prefer-todo rule #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I came up with |
|
Thanks! Can you add code for |
|
I've pushed 2 failing test cases from Jest's code base. The first crashes and the second is a false positive |
SimenB
reviewed
Jan 28, 2019
SimenB
reviewed
Jan 28, 2019
SimenB
reviewed
Jan 28, 2019
macklinu
reviewed
Jan 29, 2019
There was a problem hiding this comment.
Some initial thoughts. Thanks so much for opening this PR, @doniyor2109! 😄
SimenB
approved these changes
Jan 29, 2019
|
Thank you! |
apsarasf8
added a commit
to apsarasf8/eslint-plugin-jest
that referenced
this pull request
Aug 10, 2024
# [22.2.0](jest-community/eslint-plugin-jest@v22.1.3...v22.2.0) (2019-01-29) ### Features * **rules:** add prefer-todo rule ([#218](jest-community/eslint-plugin-jest#218)) ([abe1bfd](jest-community/eslint-plugin-jest@abe1bfd)), closes [#217](jest-community/eslint-plugin-jest#217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added prefer-todo rule as mentioned #217