Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-large-snapshots): add setting to define maxSize by snapshot type #524

Merged
merged 2 commits into from
Feb 23, 2020
Merged

feat(no-large-snapshots): add setting to define maxSize by snapshot type #524

merged 2 commits into from
Feb 23, 2020

Conversation

leonardovillela
Copy link
Contributor

Closes #244

@G-Rath G-Rath self-assigned this Jan 23, 2020
G-Rath
G-Rath requested changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

docs/rules/no-large-snapshots.md Outdated Show resolved Hide resolved
src/rules/no-large-snapshots.ts Outdated Show resolved Hide resolved
src/rules/no-large-snapshots.ts Outdated Show resolved Hide resolved
@leonardovillela
Copy link
Contributor Author

@G-Rath changes made, sorry for the delay.

G-Rath
G-Rath requested changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem!

src/rules/no-large-snapshots.ts Outdated Show resolved Hide resolved
src/rules/no-large-snapshots.ts Outdated Show resolved Hide resolved
G-Rath
G-Rath approved these changes Feb 15, 2020
View reviewed changes
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@leonardovillela
Copy link
Contributor Author

leonardovillela commented Feb 15, 2020 •
edited
Loading

You're welcome. Thanks for the patient in the review. I'm excited to contribute more in jest related projects, if you have any other recommended issues, let me know.

@G-Rath
Copy link
Collaborator

G-Rath commented Feb 15, 2020 •
edited
Loading

Thanks for the patient in the review

Thanks for your patiences in being reviewed :)

I'm excited to contribute more in jest related projects.

For sure!

if you have any other recommended issues, let me know.

Will do; this package is pretty stable & feature-complete right now (most of the open issues are discussion, or waiting replies), but if anything comes up I'll keep you in mind.

If you want to go looking through jest itself & other related projects, feel free to @ me if you ever want a second pair of eyes or opinion on something :)

(btw I'll merge this sometime today - I like to try to get a chore or two landed with a release)

@G-Rath G-Rath merged commit 0d77300 into jest-community:master Feb 23, 2020
github-actions bot pushed a commit that referenced this pull request Feb 23, 2020
@semantic-release-bot
chore(release): 23.8.0 [skip ci]
adc3b2e 
# [23.8.0](v23.7.0...v23.8.0) (2020-02-23)

### Bug Fixes

* **valid-title:** ensure argument node is defined before accessing props ([#538](#538)) ([7730f75](7730f75))

### Features

* **no-large-snapshots:** add setting to define maxSize by snapshot type ([#524](#524)) ([0d77300](0d77300))
@github-actions
Copy link

🎉 This PR is included in version 23.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Mar 23, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

Assignees

@G-Rath G-Rath

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add different setting for no-large-snapshots for inline vs external snaps
2 participants
@leonardovillela @G-Rath