-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export rule utilities #546
Comments
we can export them, sure. @G-Rath looked into it at some point I believe |
Glad you find the utils & types useful! You should already be able to use the runtime utils by just importing them with their path relative to the plugin, but you'd need to provide a You can generate one by cloning the repo and running:
This will give you the following
To use this locally you have to wrap it in `eslint-plugin-jest.d.ts`
That file wouldn't need to be published in your package, since it's not needed at runtime. I'd be happy with shipping a For example, If something did change that you'd like to discuss or get info on, I'd be happy for you to open a new issue here :) |
@G-Rath Thanks for you answer! Keep up the good work ! |
So I'm thinking about closing this as I love that someone is finding value in these utils as I've put a lot of work into them, but I feel like everytime they change it would be breaking because of their nature (not to mention the huge refactor I'm in the progress of doing). This means if you're using them you would want to lock the version of This also means we're not bloating the published package with extra files that are probably only being used by a few people -while it's about 30kb I still think it's a mentionable tradeoff given the option of generating the types yourself. I've often thought about how these could be published, as in theory they'd be useful for If it turns out a bunch of people are actually heavily using (or would like to use) these utils, that'd be good to know. |
Closing per my comment above |
Motivation
While working on creating some internal rules for the company I currently work for I realised that in this repo there are a lot of cool utilities and types that could be super useful for creating new rules for jest that might not exactly fit in this repository.
The text was updated successfully, but these errors were encountered: