Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-if): check both types of function expression #672

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 19, 2020

Fixes #670

@SimenB I've looked at the original PR and there's no discussion around this, so I'm guessing it was working off the fact that you're meant to use arrow functions with jest?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just forgot since I haven't used them for 5+ years 😛

@G-Rath G-Rath merged commit d462d50 into master Sep 20, 2020
@G-Rath G-Rath deleted the no-if/support-function-expressions branch September 20, 2020 07:29
github-actions bot pushed a commit that referenced this pull request Sep 20, 2020
## [24.0.2](v24.0.1...v24.0.2) (2020-09-20)

### Bug Fixes

* **no-if:** check both types of function expression ([#672](#672)) ([d462d50](d462d50)), closes [#670](#670)
@github-actions
Copy link

🎉 This PR is included in version 24.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-if]: Works with arrow function, fails in standard function
2 participants