Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prefer-expect-assertions] Doesn't work within .each blocks #676

Closed
loganrosen opened this issue Sep 21, 2020 · 1 comment · Fixed by #798
Closed

[prefer-expect-assertions] Doesn't work within .each blocks #676

loganrosen opened this issue Sep 21, 2020 · 1 comment · Fixed by #798
Labels
bug released rule: prefer-expect-assertions

Comments

@loganrosen
Copy link

It appears that the prefer-expect-assertions rule does not work if your test is within a describe.each() block or if the test itself is a test.each(). It doesn't detect that there's a lack of an expect.assertions() or expect.hasAssertions() call at the beginning of the test.
G-Rath added a commit that referenced this issue Mar 21, 2021
@G-Rath
fix(prefer-expect-assertions): support .each
f20934f 
Fixes #676
@G-Rath G-Rath mentioned this issue Mar 21, 2021
Merged
G-Rath added a commit that referenced this issue Apr 2, 2021
@G-Rath
fix(prefer-expect-assertions): support .each (#798)
f758243 
Fixes #676
github-actions bot pushed a commit that referenced this issue Apr 2, 2021
@semantic-release-bot
chore(release): 24.3.3 [skip ci]
7a1ab7a 
## [24.3.3](v24.3.2...v24.3.3) (2021-04-02)

### Bug Fixes

* **no-duplicate-hooks:** support `describe.each` ([#797](#797)) ([243cb4f](243cb4f)), closes [#642](#642)
* **prefer-expect-assertions:** support `.each` ([#798](#798)) ([f758243](f758243)), closes [#676](#676)
@github-actions
Copy link

github-actions bot commented Apr 2, 2021

🎉 This issue has been resolved in version 24.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Obi-Dann Obi-Dann mentioned this issue Apr 10, 2021
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released rule: prefer-expect-assertions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(prefer-expect-assertions): support .each jest-community/eslint-plugin-jest
2 participants
@loganrosen @G-Rath