Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compression logic in CompressionHandler #12619

Open
sbordet opened this issue Dec 8, 2024 · 0 comments
Open

Improve compression logic in CompressionHandler #12619

sbordet opened this issue Dec 8, 2024 · 0 comments
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Dec 8, 2024

Jetty version(s)
12.1.x

Description
CompressionHandler logic should be improved, at least similar to GzipHandler.

  • Consider reworking the default configuration. Currently this is done via CompressionConfig.from(MimeTypes), but that method should be moved and be private, because it seems very ad-hoc and not really useful to be public.
  • Default CompressionConfig does not have any HTTP methods configured, while GzipHandler had GET and POST.
  • Should applications be able to "hint" CompressionHandler about response content encoding?
    For example, if CompressionHandler supports all 3 compression algorithms, can an application explicitly set Content-Encoding: zstd and have CompressionHandler do zstandard compression instead of one of the other?
  • Review 304 and etags
  • Add minCompressionSize to CompressionConfig.
@sbordet sbordet added the Bug For general bugs on Jetty side label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
Status: No status
Development

No branches or pull requests

2 participants