Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 11 and Micrometer #8357

Closed
tipsy opened this issue Jul 29, 2022 · 4 comments
Closed

Jetty 11 and Micrometer #8357

tipsy opened this issue Jul 29, 2022 · 4 comments
Labels
Enhancement Stale For auto-closed stale issues and pull requests

Comments

@tipsy
Copy link

tipsy commented Jul 29, 2022

Background

While migrating Javalin to Jetty 11, we discovered that Micrometer doesn't support Jetty 11. We made a ticket with the Micrometer team: micrometer-metrics/micrometer#3234, but adding support isn't straightforward.

In short, Micrometer is not able to support Jetty 11 without dropping support for Jetty 9 (not feasible), or creating a separate module (not desirable).

Feature request

It would be nice if there existed a jetty-micrometer or micrometer-jetty artifact. The Micrometer team prefers that the Jetty team provides this artifact, and I guess the Jetty team would prefer that the Micrometer team provides this. I don't know which option makes the most sense, but the Javalin team would be very happy if Micrometer and Jetty 11 could work together, so here I am.

@gregw
Copy link
Contributor

gregw commented Jul 29, 2022

We are not opposed to having 3rd party integrations in jetty where in makes sense. But hard to say we will do it without much knowledge of micrometer.
Perhaps the micrometer team could prepare a PR against jetty that would show what a "handed over" integration would look like.

@sbordet
Copy link
Contributor

sbordet commented Jul 29, 2022

Many projects are moving forward and dropping support for Java 8 and requiring at minimum Java 11.
Micrometer will have the same problem you report here when they will have to integrate Tomcat 10.1, which requires Java 11, or other projects Micrometer depends on (kafka, etc.).
It's just that Jetty 11 has bitten that bullet before.

Eventually Micrometer could decide to keep the 1.x releases for Java 8, Jetty 9, Tomcat 9, etc. and have a 2.x release for Java 11, Jetty 11, Tomcat 10.1, and so on.

We know the pain of maintaining multiple branches for multiple dependencies and Java versions and we sympathize with Micrometer, but we cannot maintain integrations for other projects for every project out there.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jul 30, 2023
@tipsy
Copy link
Author

tipsy commented Jul 30, 2023

This was resolved by the Micrometer team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Stale For auto-closed stale issues and pull requests
Projects
None yet
Development

No branches or pull requests

3 participants